DPDK Backend: Add support for tdi.json #3440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
approved these changes
Jul 15, 2022
| json->emplace("build_date", cstring(options.getBuildDate())); | ||
| json->emplace("compile_command", cstring(options.getCompileCommand())); | ||
| json->emplace("compiler_version", cstring(options.compilerVersion)); | ||
| json->emplace("schema_version", cstring("0.1")); |
There was a problem hiding this comment.
should this be a constant instead of a literal?
| json->emplace("schema_version", cstring("0.1")); | ||
| json->emplace("target", cstring("DPDK")); | ||
| } else { | ||
| json->emplace("schema_version", cstring("1.0.0")); |
There was a problem hiding this comment.
Version strings can have more than one decimal point. So I think a string literal should be ok here.
Do you mean instead of string literal, we should use a const string type variable to hold the version string?
There was a problem hiding this comment.
Yes, a const string, in one place.
|
Some ptf-ebpf checks are failing. Not related to the changes in this PR. |
mihaibudiu
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tdi json file needs to be emitted from p4c-dpdk to interface with the TDI .The contents of tdi json file is same as bfrt json with few additional program/environment related fields given below
Attached sample tdi json and corresponding bfrt json.
bfrt.json.txt
psa-example-mask-range.p4.txt
tdi.json.txt