Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only crash if the error count exceeds the maximum #3413

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Only crash if the error count exceeds the maximum #3413

merged 1 commit into from
Jun 30, 2022

Conversation

viluon
Copy link
Member

@viluon viluon commented Jun 29, 2022

This dramatic change achieves unprecedented accuracy of fatal error messages.

mihaibudiu
mihaibudiu approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@mihaibudiu mihaibudiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this is an improvement.

@viluon
Copy link
Member Author

viluon commented Jun 30, 2022

@mbudiu-vmw could you run the CI, please?

@hanw hanw merged commit 026de0a into p4lang:main Jun 30, 2022
@viluon viluon deleted the okvapil/fix-max-error-count-check branch June 30, 2022 21:33
rst0git pushed a commit to rst0git/p4c that referenced this pull request Jul 1, 2022
@viluon @rst0git
Only crash if the error count exceeds the maximum (p4lang#3413)
fd7d85e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaibudiu mihaibudiu mihaibudiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viluon @mihaibudiu @hanw