Values with type int are legal constants #3408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihai Budiu <[email protected]>
fruffy
reviewed
Jun 28, 2022
| @@ -227,6 +227,7 @@ bool ToP4::preorder(const IR::Type_Var* t) { | |||
|
|
|||
| bool ToP4::preorder(const IR::Type_Unknown*) { | |||
| BUG("Cannot emit code for an unknown type"); | |||
| // builder.append("*unknown type*"); | |||
There was a problem hiding this comment.
Comment? Is this related to the changes below?
There was a problem hiding this comment.
It is not really, but when debugging a problem I found it useful to be able not to crash when dumping an illegal IR representation.
Signed-off-by: Mihai Budiu <[email protected]>
|
yes, there was a bug in the code, I fixed it. |
fruffy
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihai Budiu [email protected]
Fixes #3394