accept PSA_MeterColor_t in action parameter #3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
approved these changes
May 26, 2022
| addActionDataField( | ||
| dataJson, param.id(), param.name(), true /* mandatory */, | ||
| false /* read_only */, makeTypeBytes(param.bitwidth()), annotations); | ||
| if (param.type_name().name() == "PSA_MeterColor_t") { |
There was a problem hiding this comment.
it may be safer to check the type of the parameter as obtained from the typeMap (the canonical type).
This may not work if the type is a typedef (unless the midend actually eliminates typedefs).
You should probably add a test for this case.
There was a problem hiding this comment.
bfrt generation happens before midend.
kamleshbhalui
commented
May 30, 2022
| @@ -973,20 +973,24 @@ class P4RuntimeAnalyzer { | |||
| auto paramType = typeMap->getType(actionParam, true); | |||
| if (!paramType->is<IR::Type_Bits>() && !paramType->is<IR::Type_Boolean>() | |||
| && !paramType->is<IR::Type_Newtype>() && | |||
| !paramType->is<IR::Type_SerEnum>()) { | |||
| !paramType->is<IR::Type_SerEnum>() && !paramType->is<IR::Type_Enum>()) { | |||
There was a problem hiding this comment.
type already checked while generating p4info here.
|
@mbudiu-vmw please review it. |
mihaibudiu
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.