Validate value_set element types #3351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihai Budiu <[email protected]>
fruffy
approved these changes
May 23, 2022
fruffy
reviewed
May 23, 2022
| @@ -1414,6 +1414,15 @@ const IR::Node* TypeInference::postorder(IR::P4ValueSet* decl) { | |||
| if (errs) | |||
| return nullptr; | |||
| } | |||
| if (!canon->is<IR::Type_Newtype>() && | |||
There was a problem hiding this comment.
This check seems a little awkward, what is the common characteristic of these types? That they have a fixed width?
There was a problem hiding this comment.
Headers may have fixed widths too, but are not allowed.
github-sajan
pushed a commit
to github-sajan/p4c
that referenced
this pull request
May 26, 2022
Signed-off-by: Mihai Budiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihai Budiu [email protected]
Fixes #3346