Add support for ternary const entries #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
approved these changes
May 23, 2022
backends/ebpf/psa/ebpfPsaTable.cpp
Outdated
| } | ||
|
|
||
| void EBPFTablePSA::emitKeysAndValues(CodeBuilder *builder, | ||
| std::vector<const IR::Entry *> &samePrefixEntries, |
There was a problem hiding this comment.
inconsistent indentation
backends/ebpf/psa/ebpfPsaTable.cpp
Outdated
| BUG("Cannot assess field bit width"); | ||
| } | ||
| builder->append("0x"); | ||
| for (int j = 0; j < width / 8; j++) |
There was a problem hiding this comment.
does this work with non-aligned widths too?
There was a problem hiding this comment.
you should factor this into a utility function getHexMask, or something of the kind.
| } | ||
| } | ||
|
|
||
| std::vector<std::vector<const IR::Entry*>> EBPFTablePSA::getConstEntriesGroupedByPrefix() { |
There was a problem hiding this comment.
A small comment would help make this function easier to interpret.
backends/ebpf/psa/ebpfPsaTable.cpp
Outdated
| std::vector<std::vector<const IR::Entry*>> EBPFTablePSA::getConstEntriesGroupedByPrefix() { | ||
| std::vector<std::vector<const IR::Entry*>> entriesGroupedByPrefix; | ||
| const IR::EntriesList* entries = table->container->getEntries(); | ||
| if (entries != nullptr) { |
There was a problem hiding this comment.
especially for long ifs I find it simpler to if (!entries) return ...;
One less level of indentation afterwards.
|
@mbudiu-vmw I've addressed comments. |
mihaibudiu
approved these changes
May 25, 2022
github-sajan
pushed a commit
to github-sajan/p4c
that referenced
this pull request
May 26, 2022
* Add support for ternary const entries in ebpf-PSA backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds possibility to use const entries with ternary tables.