Use psabpf-ctl register command in PTF tests #3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
approved these changes
May 18, 2022
| @@ -97,7 +97,7 @@ control ingress(inout headers hdr, | |||
| if (tmp.srcAddr < (bit<32>)5) { | |||
| tmp.srcAddr = (bit<32>)5; | |||
| } else { | |||
| tmp.srcAddr = tmp.srcAddr + 10; | |||
| tmp.dstAddr = tmp.dstAddr + 13; | |||
There was a problem hiding this comment.
this hardwired constant is a bit weird. It probably should be a const or #define, and perhaps documented.
|
@mbudiu-vmw Yes, they look weird but we don't have a mechanism that allow us to share |
mihaibudiu
approved these changes
May 19, 2022
github-sajan
pushed a commit
to github-sajan/p4c
that referenced
this pull request
May 26, 2022
* Use psabpf-ctl register command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
register_getandregister_setcommands to PTF tests.keyparam name in singular form (key is a list of fields).