Not all returns in parsers are disallowed #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 11, 2022 09:32
Signed-off-by: Mihai Budiu <[email protected]>
Signed-off-by: Mihai Budiu <[email protected]>
|
Fixes #3307 |
Signed-off-by: Mihai Budiu <[email protected]>
jnfoster
reviewed
May 11, 2022
| @@ -243,7 +243,7 @@ class BoolLiteral : Literal { | |||
| class StringLiteral : Literal { | |||
| cstring value; | |||
| validate{ if (value.isNull()) BUG("null StringLiteral"); } | |||
| toString{ return cstring("\"") + value + "\""; } | |||
| toString{ return cstring("\"") + value.escapeJson() + "\""; } | |||
There was a problem hiding this comment.
Is this a one-off fix or is it needed elsewhere in the .def files?
There was a problem hiding this comment.
I don't think we handle string literals anywhere else.
Signed-off-by: Mihai Budiu <[email protected]>
github-sajan
pushed a commit
to github-sajan/p4c
that referenced
this pull request
May 26, 2022
* toupper cstring method * utility function to specialize actions * Escape quotes in string literals * Returns in parsers are allowed if they are in methods Signed-off-by: Mihai Budiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.