Allow shifts with constant signed positive amounts #3303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
reviewed
May 10, 2022
| @@ -0,0 +1,4 @@ | |||
| bit<4> func(in bit<4> l) { | |||
There was a problem hiding this comment.
This function is optimized away, so it is difficult to tell how it is actually transformed.
There was a problem hiding this comment.
Indeed, but previously it was rejected altogether and now it's legal.
The new code will in fact insert a cast for (tt) to make it unsigned - only if tt is constant and positive.
There was a problem hiding this comment.
Can we make it so this test is not optimized away?
added 3 commits
May 12, 2022 19:02
Signed-off-by: Mihai Budiu <[email protected]>
Signed-off-by: Mihai Budiu <[email protected]>
Signed-off-by: Mihai Budiu <[email protected]>
fruffy
approved these changes
May 13, 2022
github-sajan
pushed a commit
to github-sajan/p4c
that referenced
this pull request
May 26, 2022
* Allow shifts with constant signed positive amounts Signed-off-by: Mihai Budiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihai Budiu [email protected]
I have deleted a test that was rejected originally but now should be fine.