Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/crash.cpp: addr2line: fcntl calls in pipe initializations fixed. #3298

Merged

Conversation

DoctorNoobingstoneIPresume
Copy link
Contributor

No description provided.

@onf-cla-manager
Copy link

Hi @DoctorNoobingstoneIPresume, this is the ONF bot 🤖 I'm glad you want to contribute to our projects! However, before accepting your contribution, we need to ask you to sign a Contributor License Agreement (CLA). You can do it online, it will take only a few minutes:

✒️ 👉 https://cla.opennetworking.org

After signing, make sure to add your Github user ID DoctorNoobingstoneIPresume to the agreement.

For more information or help:"
https://wiki.opennetworking.org/x/BgCUI

@fruffy
Copy link
Collaborator

fruffy commented Apr 14, 2023

Should we merge this? What is the reason for this change?

@apinski-cavium
Copy link

Should we merge this? What is the reason for this change?
The fix looks correct to me. we using F_SETFD and oring in FD_CLOEXEC so that should be used with F_GETFD instead of the current F_GETFL which seems wrong. FD flags vs FD status flags really.
See https://man7.org/linux/man-pages/man2/fcntl.2.html .

@fruffy fruffy merged commit 418d2d1 into p4lang:main May 16, 2023
fruffy pushed a commit that referenced this pull request May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants