Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBPF backend header files were not cpplinted #3252

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

mihaibudiu
Copy link
Contributor

Signed-off-by: Mihai Budiu [email protected]

@mihaibudiu mihaibudiu requested a review from rst0git April 27, 2022 03:20
Copy link
Member

@rst0git rst0git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rst0git
Copy link
Member

rst0git commented Apr 27, 2022

@mbudiu-vmw Would it be possible to also add make cpplint for one of the GitHub actions?

@mihaibudiu mihaibudiu merged commit abd523b into p4lang:main Apr 27, 2022
@mihaibudiu mihaibudiu deleted the cpplint branch April 27, 2022 13:16
@mihaibudiu
Copy link
Contributor Author

Make check includes make cpplint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants