Add support for Random extern to PSA/eBPF backend #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mateusz Kossakowski <[email protected]> Co-authored-by: Jan Palimąka <[email protected]>
mihaibudiu
approved these changes
Apr 26, 2022
| CHECK_NULL(di); | ||
|
|
||
| // verify type | ||
| if (!di->type->is<IR::Type_Specialized>()) { |
There was a problem hiding this comment.
but this whole sequence could be a utility function; you do this a lot in this backend.
|
you will have to resolve the conflicts |
osinstom
added a commit
to osinstom/p4c-1
that referenced
this pull request
Apr 27, 2022
Co-authored-by: Mateusz Kossakowski <[email protected]> Co-authored-by: Jan Palimąka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Mateusz Kossakowski [email protected]
Co-authored-by: Jan Palimąka [email protected]