Add support for parser value_set to eBPF backend #3235
Conversation
| explicit EBPFParser(const EBPFProgram* program, const IR::ParserBlock* block, | ||
| const P4::TypeMap* typeMap); | ||
| virtual void emitDeclaration(CodeBuilder* builder, const IR::Declaration* decl); | ||
| void emit(CodeBuilder* builder); | ||
| virtual bool build(); | ||
|
|
||
| virtual void emitTypes(CodeBuilder* builder) { (void) builder; } | ||
| virtual void emitValueSetInstances(CodeBuilder* builder) { (void) builder; } | ||
| virtual void emitTypes(CodeBuilder* builder); |
There was a problem hiding this comment.
So this works with the standard ebpf backend too. Thank you.
backends/ebpf/ebpfTable.cpp
Outdated
| // validate type | ||
| if (pvs->elementType->is<IR::Type_Bits>() || pvs->elementType->is<IR::Type_Tuple>()) { | ||
| // no restrictions | ||
| } else if (pvs->elementType->is<IR::Type_Name>()) { |
There was a problem hiding this comment.
In general you can do typeMap->getType(pvs->elementType, true).
This should cover all cases, including nested typedefs, etc.
There was a problem hiding this comment.
getType returns instance of IR::Type_Type. This is intended behavior?
backends/ebpf/ebpfTable.cpp
Outdated
| } | ||
|
|
||
| void EBPFValueSet::emitTypes(CodeBuilder* builder) { | ||
| if (pvs->elementType->is<IR::Type_Name>()) { |
There was a problem hiding this comment.
Same here, use the typeMap.
backends/ebpf/ebpfTable.cpp
Outdated
| builder->endOfStatement(true); | ||
| }; | ||
|
|
||
| if (pvs->elementType->is<IR::Type_Bits>()) { |
There was a problem hiding this comment.
Here as well it is safest to use the type from the typeMap.
backends/ebpf/ebpfTable.cpp
Outdated
|
|
||
| // init other bigger fields | ||
| for (unsigned int i = 0; i < fieldNames.size(); i++) { | ||
| if (fieldNames.at(i).second->is<IR::Type_Bits>()) { |
There was a problem hiding this comment.
why do a separate loop? Can't this case be handled in the above loop?
There was a problem hiding this comment.
I've changed the way that key is initialized, so now it is one loop.
This PR adds the support for parser value_set to eBPF backend. Co-authored-by: Tomasz Osiński <[email protected]> Co-authored-by: Mateusz Kossakowski <[email protected]>
|
@mbudiu-vmw I think I addressed all the comments, thank you for your review. |
This PR adds the support for parser value_set to eBPF backend.
Co-authored-by: Tomasz Osiński [email protected]
Co-authored-by: Mateusz Kossakowski [email protected]