Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow casts int to int #3220

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Allow casts int to int #3220

merged 2 commits into from
Apr 15, 2022

Conversation

mihaibudiu
Copy link
Contributor

Fixes #3219

@mihaibudiu mihaibudiu requested a review from fruffy April 15, 2022 20:55
fruffy
fruffy approved these changes Apr 15, 2022
View reviewed changes
testdata/p4_16_samples/issue3219.p4
@@ -0,0 +1,9 @@
bit<4> func1() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this a test that produces an output? We'll see whether Gauntlet needs fixing..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Example containing main
9b187e0 
Signed-off-by: Mihai Budiu <[email protected]>
@mihaibudiu mihaibudiu merged commit a923b7c into p4lang:main Apr 15, 2022
@mihaibudiu mihaibudiu deleted the issue3219 branch April 15, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fruffy fruffy fruffy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cast int -> int is illegal
2 participants
@mihaibudiu @fruffy