Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dpdk] Emit key name in context file as in bfrt and p4info #3205

Merged
merged 1 commit into from
Apr 13, 2022
Merged

[dpdk] Emit key name in context file as in bfrt and p4info #3205

merged 1 commit into from
Apr 13, 2022

Conversation

kamleshbhalui
Copy link
Contributor

No description provided.

mihaibudiu
mihaibudiu approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@mihaibudiu mihaibudiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the other program outputs change?

backends/dpdk/dpdkContext.cpp Outdated
@@ -85,12 +85,13 @@ void DpdkContextGenerator::CollectTablesAndSetAttributes() {

// This functions insert a single key field in the match keys array
void DpdkContextGenerator::addKeyField(
Util::JsonArray* keyJson, const cstring name, const IR::KeyElement *key, int position) {
Util::JsonArray* keyJson, const cstring name, const cstring annon, const IR::KeyElement *key,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would name the parameter "nameAnnotation". annon suggests "annonymous".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! done.

@kamleshbhalui
Copy link
Contributor Author

None of the other program outputs change?
it changes output only when --context flag is passed but it's not present in test script run-dpdk-test.py, so we don't see it. It requires a fix to be able to add --context in test script.

@kamleshbhalui
Copy link
Contributor Author

@mbudiu-vmw Please merge it.

@mihaibudiu mihaibudiu merged commit d089c53 into p4lang:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaibudiu mihaibudiu mihaibudiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamleshbhalui @mihaibudiu