Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typedef with generic types requires type arguments #3174

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

mihaibudiu
Copy link
Contributor

Signed-off-by: Mihai Budiu [email protected]

Fixes #3170

@mihaibudiu mihaibudiu requested a review from jnfoster April 4, 2022 22:27
@mihaibudiu
Copy link
Contributor Author

Fixes #3172
... by just forbidding the example.

@apinski-cavium
Copy link

Is this even invalid because the specification is not clear here.

@apinski-cavium
Copy link

Actually I think it should be invalid, though the specifications should be clear too.

@jnfoster
Copy link
Contributor

jnfoster commented Apr 5, 2022

I agree this was a compiler bug. Can you point out where the spec is unclear? In the example program that illustrated the bug, I'd argue a generic without its type arguments isn't really a type.

@mihaibudiu
Copy link
Contributor Author

That generic is something like a function that takes some type arguments and returns a type. Not really a type, indeed.
I think that both behaviors are reasonable (the previous one, and the current one), but since no one asked for this feature I think it's safe to not allow it.

@mihaibudiu
Copy link
Contributor Author

So, can anyone approve this PR?

@jnfoster
Copy link
Contributor

jnfoster commented Apr 5, 2022

My pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message for checking of types inside header does not say what the specialization is location is
3 participants