Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable loopsunrolling by default [recreated] #3142

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Enable loopsunrolling by default [recreated] #3142

wants to merge 12 commits into from

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Mar 22, 2022

Recreation of #2921 with a different source branch.

This is a quick edit to check what happens if you enable parser unrolling for the entire p4test back end. Let's see what breaks.

@fruffy fruffy mentioned this pull request Mar 22, 2022
Closed
@fruffy
Copy link
Collaborator Author

fruffy commented Jun 17, 2022 •
edited
Loading

Please do not merge, instead rebase the branch. I will refresh the ref files.

@VolodymyrPeschanenkoIntel
Copy link
Contributor

I think that we have two bugs left in parserUnroll for this test suite:

  1. p4/testdata/p4_16_samples/invalid-hdr-warnings6.p4 (Failed)
  2. p4/testdata/p4_16_samples/issue561.p4 (Failed)
    They fixed in Solving problems with HeaderUnion #3342 and Fixing parserUnroll bug for sequential next operator usage #3193 PR's.
    We can continue after they will be merged.

@fruffy fruffy force-pushed the fruffy/p4test_unroll branch 2 times, most recently from 900e6b8 to 89c159a Compare June 22, 2022 19:25
@fruffy
Copy link
Collaborator Author

fruffy commented Jun 22, 2022

@VolodymyrPeschanenkoIntel There is two types of errors left. One of them is new it seems.

@fruffy fruffy force-pushed the fruffy/p4test_unroll branch 2 times, most recently from e1be564 to a722317 Compare July 8, 2022 13:36
fruffy
fruffy commented Jul 11, 2022
View reviewed changes
testdata/p4_14_samples_outputs/06-SimpleVlanStack-midend.p4 Outdated
default: accept;
}
}
@name(".parse_vlan_tag") state parse_vlan_tag1 {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VolodymyrPeschanenkoIntel It is probably a good idea to preserve the annotation only for the original state but do not add it to the follower states. This might lead to issues with the control plane otherwise

@fruffy fruffy force-pushed the fruffy/p4test_unroll branch 2 times, most recently from 95aad2f to 01356e6 Compare July 18, 2022 20:34
@fruffy fruffy mentioned this pull request Aug 25, 2022
Merged
@VolodymyrPeschanenkoIntel VolodymyrPeschanenkoIntel mentioned this pull request Nov 22, 2022
Merged
@fruffy
Copy link
Collaborator Author

fruffy commented Dec 16, 2022

@VolodymyrPeschanenkoIntel Can you take a look at the last two failing tests?

@jafingerhut
Copy link
Contributor

@fruffy Is this PR still useful? Or perhaps other PRs have done everything you planned to do with this one already?

@fruffy
Copy link
Collaborator Author

fruffy commented Aug 20, 2023

@fruffy Is this PR still useful? Or perhaps other PRs have done everything you planned to do with this one already?

It is effectively a debugging PR for the loopsunrolling pass. It has not been merged yet because it was not 100% clear whether the pass is bug free. Let me rebase it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fruffy @VolodymyrPeschanenkoIntel @jafingerhut @VolodymyrPeschanenko