Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct and error test cases for structure-values expressions #3100

Merged

Conversation

jafingerhut
Copy link
Contributor

I did not find any behavior that I would consider a bug in writing these tests, but I also did not see any existing tests that exercise some of these compile-time error catching cases in the p4_16_errors_outputs directory, so it seems they are not exercised by any existing test cases before these.

Copy link
Member

@rst0git rst0git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mihaibudiu mihaibudiu merged commit beca37c into p4lang:main Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants