Fix invalid string format specifier (#4145)

p4lang · Sep 8, 2023 · 87d362f · 87d362f
1 parent 1902890
commit 87d362f
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 1 deletion.
diff --git a/ir/ir.cpp b/ir/ir.cpp
@@ -278,7 +278,7 @@ const IR::PackageBlock *ToplevelBlock::getMain() const {
         return nullptr;
     }
     if (!main->is<IR::Declaration_Instance>()) {
-        ::error(ErrorType::ERR_INVALID, "%1$: must be a package declaration", main->getNode());
+        ::error(ErrorType::ERR_INVALID, "%1%: must be a package declaration", main->getNode());
         return nullptr;
     }
     auto block = getValue(main->getNode());

diff --git a/testdata/p4_16_errors/issue4144.p4 b/testdata/p4_16_errors/issue4144.p4
@@ -0,0 +1,3 @@
+#include <core.p4>
+
+extern main {}
diff --git a/testdata/p4_16_errors_outputs/issue4144-first.p4 b/testdata/p4_16_errors_outputs/issue4144-first.p4
@@ -0,0 +1,5 @@
+#include <core.p4>
+
+extern main {
+}
+
diff --git a/testdata/p4_16_errors_outputs/issue4144-frontend.p4 b/testdata/p4_16_errors_outputs/issue4144-frontend.p4
@@ -0,0 +1,5 @@
+#include <core.p4>
+
+extern main {
+}
+
diff --git a/testdata/p4_16_errors_outputs/issue4144.p4 b/testdata/p4_16_errors_outputs/issue4144.p4
@@ -0,0 +1,5 @@
+#include <core.p4>
+
+extern main {
+}
+
diff --git a/testdata/p4_16_errors_outputs/issue4144.p4-stderr b/testdata/p4_16_errors_outputs/issue4144.p4-stderr
@@ -0,0 +1,3 @@
+issue4144.p4(3): [--Werror=invalid] error: main: must be a package declaration
+extern main {}
+       ^^^^