Review comments.

p4lang · Apr 14, 2023 · 25c9f67 · 25c9f67
1 parent cb0e759
commit 25c9f67
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/backends/p4tools/modules/testgen/lib/concolic.h b/backends/p4tools/modules/testgen/lib/concolic.h
@@ -27,7 +27,8 @@ namespace P4Tools::P4Testgen {
 /// are present, but not expressions. The reason expressions need to be keys is that sometimes
 /// entire expressions are mapped to a particular constant.
 using ConcolicVariableMap =
-    std::map<std::variant<const IR::StateVariable, const IR::Expression *>, const IR::Expression *>;
+    ordered_map<std::variant<const IR::StateVariable, const IR::Expression *>,
+                const IR::Expression *>;
 
 /// Encapsulates a set of concolic method implementations.
 class ConcolicMethodImpls {

diff --git a/backends/p4tools/modules/testgen/lib/test_backend.cpp b/backends/p4tools/modules/testgen/lib/test_backend.cpp
@@ -63,7 +63,6 @@ const Model *TestBackEnd::computeConcolicVariables(const ExecutionState *executi
             const auto *concolicAssignment = resolvedConcolicVariable.second;
             const IR::Expression *pathConstraint = nullptr;
             // We need to differentiate between state variables and expressions here.
-            // We need to differentiate between state variables and expressions here.
             if (std::holds_alternative<const IR::StateVariable>(concolicVariable)) {
                 pathConstraint = new IR::Equ(std::get<const IR::StateVariable>(concolicVariable),
                                              concolicAssignment);

diff --git a/backends/p4tools/modules/testgen/test/z3-solver/expressions.cpp b/backends/p4tools/modules/testgen/test/z3-solver/expressions.cpp
@@ -123,9 +123,9 @@ void test(const IR::Expression *expression, const IR::AssignmentStatement *varia
 
     // getting model
     Model model = *solver.getModel();
-    ASSERT_EQ(model.size(), 2u);
+    ASSERT_EQ(model.size(), 2U);
 
-    ASSERT_EQ(model.count(variableValue->left->checkedTo<IR::Member>()), 1u);
+    ASSERT_EQ(model.count(variableValue->left->checkedTo<IR::Member>()), 1U);
 
     const auto *value = model.at(variableValue->left->checkedTo<IR::Member>());