[DO NOT MERGE] Remove rules_cc and fix builds for Google internal projects #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qobilidop
force-pushed
the
temp-remove-rules-cc
branch
2 times, most recently
from
9493daa to
e0b49f7
Compare
|
@Shoooooon I think this might be easier to maintain on top of HEAD than creating a separate feature branch as proposed in #176. |
I agree -- having a commit to refer to is sufficient. |
qobilidop
force-pushed
the
temp-remove-rules-cc
branch
from
e0b49f7 to
e5e9c77
Compare
Signed-off-by: Bili Dong <[email protected]>
qobilidop
force-pushed
the
temp-remove-rules-cc
branch
from
e5e9c77 to
84e9c43
Compare
Signed-off-by: Bili Dong <[email protected]>
qobilidop
force-pushed
the
temp-remove-rules-cc
branch
14 times, most recently
from
b31aea6 to
21b1bae
Compare
Signed-off-by: Bili Dong <[email protected]>
qobilidop
force-pushed
the
temp-remove-rules-cc
branch
from
21b1bae to
5b6ec72
Compare
qobilidop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explicit
rules_ccusage is causing some trouble building things internally at Google. So we want to use this temporary hack to unblock some internal work. We only need a commit to refer to. So this PR is not intended to be merged. I'll close this PR once the hack is no longer needed.