Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/modify MGID logging bm_sim. #1285

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Add/modify MGID logging bm_sim. #1285

merged 2 commits into from
Jan 7, 2025

Conversation

angelazhang8
Copy link
Contributor

  • Log MGID in simple_pre_lag.cpp in addition to simple_pre.cpp.
  • Change the log message to be consistent with other MGID logging.

jafingerhut
jafingerhut approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jafingerhut
Copy link
Contributor

@angelazhang8
I am hoping that when creating this PR, you have checked carefully for any other similar places in the code that might exist?

@angelazhang8
Copy link
Contributor Author

@angelazhang8 I am hoping that when creating this PR, you have checked carefully for any other similar places in the code that might exist?

Yes, that has been checked. Additionally, I ran some tests in google3 to generate BMv2 logs and verified the modified log gets printed.

@kheradmandG
Copy link

LGTM from our side.

@jafingerhut jafingerhut merged commit 87e6bf3 into p4lang:main Jan 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafingerhut jafingerhut jafingerhut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angelazhang8 @jafingerhut @kheradmandG