Merged
Conversation
The new test that was added to distinguish GNU/XSI strerror_r ran a compiled program, which doesn't work when cross-compiling. The only difference at compile time is that the GNU version returns char * and the XSI version returns int, so detect it by compiling a program that dereferences the return value. Signed-off-by: Adam Sampson <ats@offog.org>
The Meson check for GNU/XSI strerror_r didn't inherit the project options that include _GNU_SOURCE (unlike the autoconf version), so the result didn't match how the code that uses it will be compiled. Add _GNU_SOURCE explicitly as with the following checks. Signed-off-by: Adam Sampson <ats@offog.org>
atsampson
force-pushed
the
strerror_r-crosscompile
branch
from
400780b to
cc618c0
Compare
Member
|
Thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new test that was added to distinguish GNU/XSI strerror_r ran a compiled program, which doesn't work when cross-compiling. The only difference at compile time is that the GNU version returns char * and the XSI version returns int, so detect it by compiling a program that dereferences the return value.
Testing this revealed that the autoconf and meson version of the checks produce different results, because the meson version doesn't define _GNU_SOURCE (even though the rest of the code is compiled with it) - the second commit fixes that.