Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_args(): work around GCC 12 warning bug. #359

Merged
merged 1 commit into from
May 20, 2024

Conversation

ericonr
Copy link
Contributor

@ericonr ericonr commented May 20, 2024

This bug [1] causes GCC to emit a wrong warning when adding a short string literal to a std::string. Wrapping the literal in a std::string doesn't have a large impact and avoids the warning.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105329


Fixes #358

This bug [1] causes GCC to emit a wrong warning when adding a short
string literal to a std::string. Wrapping the literal in a std::string
doesn't have a large impact and avoids the warning.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105329
@p-ranav p-ranav merged commit eab1d75 into p-ranav:master May 20, 2024
8 checks passed
@ericonr ericonr deleted the string-warning branch May 20, 2024 20:52
iTrooz added a commit to iTrooz/PatternLanguage that referenced this pull request May 27, 2024
ericonr added a commit to lnls-dig/uhal that referenced this pull request Sep 10, 2024
This release includes a workaround for a bogus GCC warning [1].

[1] p-ranav/argparse#359
ericonr added a commit to lnls-dig/uhal that referenced this pull request Sep 12, 2024
This release includes a workaround for a bogus GCC warning [1].

[1] p-ranav/argparse#359
ericonr added a commit to lnls-dig/uhal that referenced this pull request Sep 13, 2024
This release includes a workaround for a bogus GCC warning [1].

[1] p-ranav/argparse#359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-Wrestrict warning on Alpine 3.18, using GCC 12 and C++20, unclear if actual bug
2 participants