Convert default value using action() #350
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using an
action()
to convert the input values into custom data types, the default value poses an issue when usingchoices()
.m_choices
is avector<string>
so the default value also has to be comparable to a string, for the given value to be accepted.This commit solves this by patching
get()
to convert the default value using the sameaction()
.It is not the cleanest solution (default value has to be given as string instead of the target type), but the alternative I came up with would have changed
m_choices
to a typed vector which would have had wider consequences so I didn't pursue that path.