Fix for C++23 standard library module usage. #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<errno> header exposes errno macro, which cannot be exported in C++ module. It must always included regardless of module usage.
To use <cstdlib> feature, std.compat module should be imported.
Fix typo
p-ranav
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently argparse cannot be built using
ARGPARSE_MODULE_ENABLE_STD_MODULEmacro, because there are two problems.argparse.hpp, the header<cerrno>should be outside the macro if statement becauseerrnomacro variable cannot be exported via C++ module.argparse.cppm, to use<cstdlib>features,std.compatmodule should also be imported.This PR's commits include these fixes.