Change parse_args readme and samples to catch const std::exception& #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse_args can throw exceptions that are not based on std::runtime_error, and the error message should show on all errors.
For example, if a user is using a program formatted as:
and the user messes up by misformatting the "number" positional argument, this will throw an std::invalid_argument from argparse::details::do_from_chars. However, std::invalid_argument inherits from std::logic_error, not std::runtime_error, so the user will just have an aborted program with no help message. In order to keep the code simple while not having to catch std::runtime_error and std::logic_error separately, the user could use std::exception instead to catch all errors of parse_args.