add binary number parsing #271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaiku
reviewed
Jul 28, 2023
| scientific = 0xf1, | ||
| fixed = 0xf2, | ||
| hex = 0xf4, | ||
| bin = 0xf8, |
There was a problem hiding this comment.
Why did you change the one-hot encoding to set all the upper bits?
There was a problem hiding this comment.
because radix_2 = 2 collides with fixed in template struct parse_number<T, chars_format::fixed> on line 383
|
Hello! Congratulations on the first contribution. In addition to the code that adds new functionality, it is highly desirable to also write tests and a documentation with examples in |
|
Merged in #306 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that's pretty much it, i needed(wanted) binary numbers, its my first contribution to any project ever so i hope its not stupid