Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves the std::numeric_limits<std::size_t>::max)()} error #263

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

nick20201
Copy link
Contributor

Hi @p-ranav
I really liked the API of this project, thank you for sharing your work
It helped me a lot.
However, I couldn't compile it at first.
This merge request fixes the issue
The problem was similar to this one microsoft/cppwinrt#479
Hope it helps someone too
Happy coding 😄

Copy link
Contributor

@skrobinson skrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This looks good and I appreciate that you use std::min<T> where possible. I'd like to see our test runners try this PR to make sure it does not break other tool chains, but I expect it is fine as is.

@p-ranav p-ranav merged commit 34ba129 into p-ranav:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants