implements column-aligned multi-line help message for arguments #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| prev += pos - prev + 1; | ||
| } | ||
| if (first_line) |
There was a problem hiding this comment.
statement should be inside braces
Suggested change
| if (first_line) | |
| if (first_line) { |
| } | ||
| if (first_line) | ||
| stream << "\t" << argument.m_help; | ||
| else { |
There was a problem hiding this comment.
statement should be inside braces
Suggested change
| else { | |
| } else { |
| stream << "\t" << argument.m_help; | ||
| else { | ||
| auto leftover = argument.m_help.substr(prev, argument.m_help.size() - prev); | ||
| if (leftover.size() > 0) { |
There was a problem hiding this comment.
the empty method should be used to check for emptiness instead of size
Suggested change
| if (leftover.size() > 0) { | |
| if (!leftover.empty()) { |
|
Please fix these minor clang-tidy issues and then we can merge it in 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'd like to provide this little implementation regarding column-aligned multi-line help message that works for arguments (not subcommands). This was discussed in #248 but the original poster didn't open a pull request.
In test_help.cpp I didn't see a test that validates the help message on a per-character level, so I didn't write any test.