Various maintenance tasks #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://learn.microsoft.com/en-us/cpp/overview/visual-cpp-language-conformance?view=msvc-170 Closes p-ranav#228 Reported-by: @c0rn1ie Signed-off-by: Sean Robinson <[email protected]>
This replaces the verbiage copied from the Python argparse documentation and makes the code sample more concrete. This illustrates how to avoid the multiple help output problem reported in p-ranav#165. Closes p-ranav#165 Signed-off-by: Sean Robinson <[email protected]>
The intent of ": 1" is to use individual bits to store the bool state of these class values. Because true != 0, this worked. But it was likely to bite someone sometime. (My bad: 0fe17e2.) This commit also adds m_accepts_optional_like_value to the bit field and sets the default false value in the constructor. Because we cannot set a default value during declaration (until C++20). make sure future coders know to set the preferred default in the constructor. Closes p-ranav#213 Signed-off-by: Sean Robinson <[email protected]>
Signed-off-by: Sean Robinson <[email protected]>
This attempts to fix Issue p-ranav#225-1 by reverting the change that turned a std::bad_any_cast exception into a nullptr. Reverts commit 3570681. Signed-off-by: Sean Robinson <[email protected]>
This was made obsolete by commit ea1f7ef. Signed-off-by: Sean Robinson <[email protected]>
The option() command expects a help string between the variable and the initial value. Closes p-ranav#241 Signed-off-by: Sean Robinson <[email protected]>
skrobinson
force-pushed
the
fix-maintenance
branch
from
897c47a to
d0beb40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.