Allow check if ArgumentParser has parsed values

[skrobinson]

No description provided.

[github-actions]

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

[SergiusTheBest]

@skrobinson Why don't we use just m_is_parsed? I have a subcommand without arguments and operator bool() returns false for it.

[skrobinson]

@SergiusTheBest The question I'm trying to answer with this operator bool() is: has this parser (or it's subparsers) run and found values. Using only m_is_parsed would only indicate the parser ran without an error, not that any values were parsed.

For the case where subparsers are commands and don't require any arguments the ArgumentParser::is_subcommand_used() function may better match your needs.

[SergiusTheBest]

@skrobinson I understand. But it's not so obvious as operator bool() is very generic and is better suited for m_is_parsed than m_is_parsed && (arg_used || subparser_used) (taking into account that arguments are optional and not required for a command).

[SergiusTheBest]

@skrobinson BTW, is a test case required for contributing? I'd like to add ArgumentParser::is_subcommand_used(const ArgumentParser& subcommand).

[skrobinson]

Test cases are encouraged. You could probably add to and adapt tests in test/test_subparsers.cpp rather than writing new tests.

I believe your new overload is a good idea.

[SergiusTheBest]

Ok, thanks for the hint.