Add clang-tidy analysis of pull requests #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This action runs clang-tidy with results saved to a file which is then parsed in stage two to post code comments. This multistage process lets us post PR comments on code from forks. Signed-off-by: Sean Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an alternate to the previously tried
JacobDomagala/StaticAnalysis.platisd/clang-tidy-pr-commentsonly offersclang-tidychecks, but provides security-compatible use patterns that will allow running checks with PRs from forks.See an example at skrobinson/pull/8. I'm hoping this action will work as nicely with forks as the example works with branches.