Update CI hosts and fix clang-cl build #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windows-latest changed to Windows 2022 during first quarter of 2022. This adds windows-2019 to CI test matrix do that we can catch changes that break the older configuration. Signed-off-by: Sean Robinson <[email protected]>
This expands test environment coverage to two MacOS versions. Signed-off-by: Sean Robinson <[email protected]>
Several people using clang-cl on Windows are reporting build errors after a upgrading to v13. This tries to replicate the error to allow testing a fix. Signed-off-by: Sean Robinson <[email protected]>
The new "windows-latest-clang" target does not honor the CXX environment variable and uses the default MSVC compiler. This tries to tell cmake to handle things via a toolset name. Signed-off-by: Sean Robinson <[email protected]>
clang-ci >= 13.0 is failing to compile a constexpr function pointer assignment. This is possibly due to strtof (and family) not being implemented as constexpr in the relevant libc++. Closes p-ranav#136 Closes p-ranav#156 Signed-off-by: Sean Robinson <[email protected]>
skrobinson
force-pushed
the
wip-update-ci-hosts
branch
from
dbdacc2 to
a8e2823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been hosting changes and we could expand to more test environments.