Actions with nonary arguments, removable defaults, and some clean ups #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrobinson
force-pushed
the
wip-deactivatable-defaults
branch
2 times, most recently
from
9b93643 to
b1e2112
Compare
p-ranav
approved these changes
Oct 26, 2021
|
Do you know what the problem is with the CI? |
|
Unfortunately, the test failure only shows with
The MSVC 2019 build runs fine. This may take some time to track down. |
skrobinson
force-pushed
the
wip-deactivatable-defaults
branch
from
b1e2112 to
60c3d0b
Compare
argparse seems to use the "std::" qualifier for std namespace members, continue that in the documentation. Signed-off-by: Sean Robinson <[email protected]>
These examples give a false impression that a space in the middle of the application name is well handled. While a space might be possible, it must be escaped in shells, i.e. a common environment for a CLI argument parser. Signed-off-by: Sean Robinson <[email protected]>
These variables with the same name are not the same variables because of scope rules. While the compiler is not confused by this naming, it may be less readable by someone attempting to edit this code. Signed-off-by: Sean Robinson <[email protected]>
Previously, only arguments with one or more parameters would run actions. But, at times it can be useful to run an action when an argument does not expect any parameters. Closes p-ranav#104 Signed-off-by: Sean Robinson <[email protected]>
The help and version arguments are still included by default, but which default arguments to include can be overridden at ArgumentParser creation. argparse generally copies Python argparse behavior. This includes a default `--help`/`-h` argument to print a help message and exit. Some developers using argparse find the automatic exit to be undesirable. The Python argparse has an opt-out parameter when constructing an ArgumentParser. Using `add_help=False` avoids adding a default `--help` argument and allows the developer to implement a custom help. This commit adds a similar opt-out to our C++ argparse, but keeps the current behavior as the default. The `--help`/`-h` and `--version`/`-v` Arguments handle their own output and exit rather than specially treating them in ArgumentParser::parse_args_internal. Closes p-ranav#119 Closes p-ranav#138 Closes p-ranav#139 Signed-off-by: Sean Robinson <[email protected]>
Help output has changed format over time. This updates the README example to reflect current practice by running the example code and copy-pasting its output. Signed-off-by: Sean Robinson <[email protected]>
skrobinson
force-pushed
the
wip-deactivatable-defaults
branch
from
60c3d0b to
5cceb98
Compare
|
I was able to resolve this faster than I expected. This branch has been rebased on the post-#143 master and now passes tests in our five OS/compiler environments. While researching the test fails, I saw that the GitHub windows-2016 environment is deprecated will be disabled in early 2022. Sometime before then, I'll submit a PR removing that config from our tests. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen several requests to change the behavior of
--helpand--versionwith regard to exit() ending program execution. On the way to solving these requests, I needed to add nonary argument actions. This patch series includes other small fixes found along the way.