Document and use Argument.scan where possible #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMHO, the .scan function and its supporting functions are beautiful metaprogramming that needs to be more visible to argparse users. As a start, document the function, with simple examples. Signed-off-by: Sean Robinson <[email protected]>
…README To better show the built-in conversion to a primitive type, use .scan in examples. Signed-off-by: Sean Robinson <[email protected]>
…tests Argument.scan handles simple string to numeric type conversions, removing the need to create a lambda. Argument.action is still necessary for more complex conversions and those are left unchanged. Signed-off-by: Sean Robinson <[email protected]>
p-ranav
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.