Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit conversion changes signedness warnings #94

Closed
bear24rw opened this issue Jan 8, 2021 · 0 comments
Closed

Implicit conversion changes signedness warnings #94

bear24rw opened this issue Jan 8, 2021 · 0 comments

Comments

@bear24rw
Copy link

bear24rw commented Jan 8, 2021

My project has -Wsign-conversion turned on and it triggers some warnings in argparse:

/libs/argparse/include/argparse/argparse.hpp:626:26: warning: implicit conversion changes signedness: 'long' to 'std::__1::basic_string_view::size_type' (aka 'unsigned long') [-Wsign-conversion]
      return s.substr(it - begin(s));
               ~~~~~~ ~~~^~~~~~~~~~
/libs/argparse/include/argparse/argparse.hpp:953:22: warning: implicit conversion changes signedness: 'size_t' (aka 'unsigned long') to 'std::__1::streamsize' (aka 'long') [-Wsign-conversion]
        stream.width(tLongestArgumentLength);
               ~~~~~ ^~~~~~~~~~~~~~~~~~~~~~
/libs/argparse/include/argparse/argparse.hpp:962:22: warning: implicit conversion changes signedness: 'size_t' (aka 'unsigned long') to 'std::__1::streamsize' (aka 'long') [-Wsign-conversion]
        stream.width(tLongestArgumentLength);
               ~~~~~ ^~~~~~~~~~~~~~~~~~~~~~
/libs/argparse/include/argparse/argparse.hpp:442:32: warning: implicit conversion changes signedness: 'std::__1::optional<unsigned long>::value_type' (aka 'unsigned long') to 'typename
      iterator_traits<__wrap_iter<const basic_string<char> *> >::difference_type' (aka 'long') [-Wsign-conversion]
        end = std::next(start, *expected);
              ~~~              ^~~~~~~~~
clang version 11.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant