Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Almost [Required] (help text) #89

Closed
rysson opened this issue Nov 30, 2020 · 0 comments
Closed

Almost [Required] (help text) #89

rysson opened this issue Nov 30, 2020 · 0 comments

Comments

@rysson
Copy link
Contributor

rysson commented Nov 30, 2020

Argument with .required() flag and with default value is not so required (can be omitted in command-line).
I think that [Required] is not necessary in this case.

A propose skip this text if argument has default value

    if (argument.mIsRequired && !argument.mDefaultValue.has_value()) 
      stream << "[Required]";
@rysson rysson changed the title Almost [Required] Almost [Required] (help text) Nov 30, 2020
p-ranav added a commit that referenced this issue Nov 30, 2020
Fix help if required and def-value. Fixes #89.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant