Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged too fast. #5

Closed
SuperWig opened this issue Apr 10, 2019 · 5 comments
Closed

Merged too fast. #5

SuperWig opened this issue Apr 10, 2019 · 5 comments

Comments

@SuperWig
Copy link
Contributor

I made a mistake.
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>/include)

Should be CMAKE_CURRENT_LIST_DIR not SOURCE_DIR. Literally just fixed it as you merged lol.
@p-ranav
Copy link
Owner

p-ranav commented Apr 10, 2019

Hah. Merging too fast is definitely an issue. I'll be more careful next time.

p-ranav added a commit that referenced this issue Apr 10, 2019
@p-ranav
Fixes issue #5
483e9f2
@p-ranav p-ranav closed this as completed Apr 10, 2019
@SuperWig
Copy link
Contributor Author

Also I left the version as a placeholder related to #3

Also I don't know how to do the package version on CMake side of things 🤷‍♂️

@p-ranav
Copy link
Owner

p-ranav commented Apr 10, 2019

If I'm not mistaken, issue #3 is requesting a git tag for the current version and all future releases. I'll set this up sometime tomorrow and update the CMakeLists to reflect the version number of the master branch.

@p-ranav
Copy link
Owner

p-ranav commented Apr 10, 2019

Thanks for the contribution! :)

@SuperWig
Copy link
Contributor Author

That's what I meant, for it to reflect the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SuperWig @p-ranav