Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Actions to run tests for PR #128

Closed
skrobinson opened this issue Sep 13, 2021 · 1 comment · Fixed by #129
Closed

Add GitHub Actions to run tests for PR #128

skrobinson opened this issue Sep 13, 2021 · 1 comment · Fixed by #129

Comments

@skrobinson
Copy link
Contributor

Is there any interest in using GitHub Actions to run tests on pull requests?

I have set up a proof of concept (e.g. it does not quite work as I would hope) on my argparse fork at https://github.com/skrobinson/argparse/actions/workflows/ci.yml to show the potential. If this is something we want to have, I can polish this into a PR.
@p-ranav
Copy link
Owner

p-ranav commented Sep 13, 2021

There is definitely interest. Having to run the tests for each PR is annoying and it would be good to have the action run the tests. Likewise, it would be good to run cppcheck or other static analysis and have the action make a comment on the PR with "No issues found" or "3 issues found" along with comments in code. I've used this in other projects: https://github.com/JacobDomagala/StaticAnalysis

skrobinson added a commit to skrobinson/argparse that referenced this issue Sep 13, 2021
@skrobinson
Add GitHub Action to run tests on pull request
335e627 
Run tests on Apple macOS, MS Windows, and Ubuntu Linux hosts.

macOS-hosted tests are only run on latest, which is currently macOS 10.15.
GH will eventually update latest to macOS 11 and we can look at expanding
to two versions of macOS.

Windows-hosted tests run on Windows Server 2016 and latest.

Ubuntu-hosted tests only run on latest because g++ fails to build argparse
on ubuntu-18.04 (GCC 8) since charconv was added in commit ea2f16d.  But,
Ubuntu-hosted tests do run with g++ and clang++.

Closes p-ranav#128.

Signed-off-by: Sean Robinson <[email protected]>
This was referenced Sep 13, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add GitHub Action to run tests on pull request skrobinson/argparse
2 participants
@p-ranav @skrobinson