Autotime - Getting SectionEnd from YouTube #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ozencb Would love to have this added |
|
|
|
Hi, sorry for the late reply. I am afraid I don't have much time to keep working on this project but I wish to return back one day. This looks awesome but I think it should be an optional feature. It is nice not having to create API keys. |
|
That's a good point, there should be a toggle to enable the behavior. I guess right now if you had tried it without a api key it'd just error out and probably crash couchtube. Sadly I'm in the same situation, I don't have time to implement those changes. I'm not going to close the pull request, I'll revisit this later when I have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not made many open source contributions, so I will try to describe what I have done as best I can.
Firstly, in db/init.go there is now logic to detect when SectionStart and SectionEnd are both 0, indicating that they have not been set by the user. If detected, the youtube api golang package will look up the video by it's ID, grab the duration of the video, and set that as the SectionEnd value so that the whole video plays.
Secondly, in config/env.go I have added a YOUTUBE_API_KEY key that allows a user to put in their api key for youtube so that this functionality can work.
That should be it, at a high level! I hope I haven't messed anything up.