Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy setting #106

Merged
merged 4 commits into from
Feb 16, 2021
Merged

deploy setting #106

merged 4 commits into from
Feb 16, 2021

Conversation

YuMuuu
Copy link
Contributor

@YuMuuu YuMuuu commented Feb 12, 2021

#93

build成果物をgh-pages branchにpushする

https://github.com/peaceiris/actions-gh-pages#%EF%B8%8F-set-another-github-pages-branch-publish_branch

TODO

  • .eslintignore に /out を追加する(開発環境でeslintが固まる)
  • CDの設定を行う(github Actionsでmasterにpushしたときにdeployを実行する)

動作確認

実際にgh-pages branchにpushして確認するわけにはいかないのでgithub action上でdevelop/gh-pages branchにpushできるかを検証する。
491b932
7e3f0e0
push出来ている

@YuMuuu YuMuuu mentioned this pull request Feb 13, 2021
@YuMuuu YuMuuu force-pushed the feature/#93-deploy-settings branch from 7af03ab to 4d72764 Compare February 15, 2021 16:35
@YuMuuu YuMuuu marked this pull request as ready for review February 15, 2021 16:36
@YuMuuu
Copy link
Contributor Author

YuMuuu commented Feb 15, 2021

他issueも見るとmanual deploy向けのlibraryみたい
tschaub/gh-pages#345

これを使うほうが簡単そう
https://github.com/peaceiris/actions-gh-pages

@YuMuuu YuMuuu force-pushed the feature/#93-deploy-settings branch from b1a3e8f to 491b932 Compare February 15, 2021 16:55
@YuMuuu YuMuuu force-pushed the feature/#93-deploy-settings branch from d667ef1 to e24a776 Compare February 15, 2021 17:05
@YuMuuu YuMuuu requested a review from mii288 February 15, 2021 17:07
Copy link
Member

@mii288 mii288 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuMuuu YuMuuu merged commit c0762b4 into master-nextjs Feb 16, 2021
@YuMuuu YuMuuu deleted the feature/#93-deploy-settings branch February 16, 2021 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants