upgrade code analyzer to v5 #6386
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64,39 +64,37 @@ linters: | |
| linter_spdx_license: BSD-3-Clause | ||
| config_file_name: apex-pmd-ruleset.xml | ||
| cli_executable: sf | ||
| cli_config_arg_name: "--config-file" | ||
| cli_lint_extra_args: | ||
| - "code-analyzer run" | ||
| - "--rule-selector" | ||
| - "pmd:Recommended" | ||
| - "--workspace" | ||
| - "." | ||
| - "--output-file" | ||
| - "{{REPORT_FOLDER}}/code-analyzer-report-apex.csv" | ||
| - "--view" | ||
| - "table" | ||
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| cli_lint_mode: project | ||
| cli_help_extra_args: | ||
| - "code-analyzer run" | ||
| cli_help_extra_commands: | ||
| - "sf code-analyzer rules" | ||
| cli_version_extra_args: | ||
| - "plugins --core" | ||
| cli_version_arg_name: "" | ||
| version_extract_regex: "(?<=code-analyzer )\\d+(\\.\\d+)+" | ||
| cli_lint_errors_count: regex_sum | ||
| cli_lint_errors_regex: "severity: [1-3]" | ||
cursor[bot] marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| examples: | ||
| - "sf code-analyzer run --rule-selector pmd:Recommended --workspace . --output-file results.csv" | ||
| install: | ||
| dockerfile: | ||
| - |- | ||
| # renovate: datasource=npm depName=@salesforce/code-analyzer | ||
echoix marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ARG SALESFORCE_SFDX_SCANNER_VERSION=5.5.0 | ||
| - |- | ||
| RUN sf plugins install @salesforce/code-analyzer@${SALESFORCE_SFDX_SCANNER_VERSION} \ | ||
| && (npm cache clean --force || true) \ | ||
| && rm -rf /root/.npm/_cacache | ||
| ide: | ||
|
|
@@ -151,37 +149,39 @@ linters: | |
| cli_config_arg_name: ".eslintrc-aura.json" | ||
| cli_executable: sf | ||
| cli_lint_extra_args: | ||
| - "code-analyzer run" | ||
| - "--rule-selector" | ||
| - "eslint" | ||
| - "--workspace" | ||
| - "." | ||
|
There was a problem hiding this comment. Bug: Aura Linter Uses Incorrect Rule SelectorThe |
||
| - "--target" | ||
| - "**/aura/**/*.js" | ||
| - "--severity-threshold" | ||
| - "2" | ||
| - "--output-file" | ||
| - "{{REPORT_FOLDER}}/code-analyzer-report-aura.csv" | ||
| - "--view" | ||
| - "table" | ||
|
There was a problem hiding this comment. Bug: Salesforce Linter Argument Compatibility IssueThe Salesforce Aura and LWC linters mix Additional Locations (1)
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| cli_lint_mode: project | ||
| cli_help_extra_args: | ||
| - "code-analyzer run" | ||
|
||
| cli_help_extra_commands: | ||
| - "sf code-analyzer rules --rule-selector eslint" | ||
| cli_version_extra_args: | ||
| - "plugins --core" | ||
| cli_version_arg_name: "" | ||
| version_extract_regex: "(?<=code-analyzer )\\d+(\\.\\d+)+" | ||
| cli_lint_errors_count: regex_sum | ||
| cli_lint_errors_regex: "severity: [1-3]" | ||
| examples: | ||
| - "sf code-analyzer run --rule-selector eslint --workspace . --file-glob '**/aura/**/*.js' --output-file results.csv" | ||
| install: | ||
| dockerfile: | ||
| - |- | ||
| # renovate: datasource=npm depName=@salesforce/code-analyzer | ||
echoix marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ARG SALESFORCE_SFDX_SCANNER_VERSION=5.5.0 | ||
| - |- | ||
| RUN sf plugins install @salesforce/code-analyzer@${SALESFORCE_SFDX_SCANNER_VERSION} \ | ||
| && (npm cache clean --force || true) \ | ||
| && rm -rf /root/.npm/_cacache | ||
| ide: | ||
|
|
@@ -227,37 +227,39 @@ linters: | |
| cli_config_arg_name: ".eslintrc-lwc.json" | ||
| cli_executable: sf | ||
| cli_lint_extra_args: | ||
| - "code-analyzer run" | ||
|
||
| - "--rule-selector" | ||
| - "eslint:LWC" | ||
| - "--workspace" | ||
| - "." | ||
| - "--target" | ||
| - "**/lwc/**/*.js" | ||
| - "--severity-threshold" | ||
| - "2" | ||
| - "--output-file" | ||
| - "{{REPORT_FOLDER}}/code-analyzer-report-lwc.csv" | ||
| - "--view" | ||
| - "table" | ||
echoix marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| cli_lint_mode: project | ||
| cli_help_extra_args: | ||
| - "code-analyzer run" | ||
| cli_help_extra_commands: | ||
| - "sf code-analyzer rules --rule-selector eslint:LWC" | ||
| cli_version_extra_args: | ||
| - "plugins --core" | ||
| cli_version_arg_name: "" | ||
| version_extract_regex: "(?<=code-analyzer )\\d+(\\.\\d+)+" | ||
| cli_lint_errors_count: regex_sum | ||
| cli_lint_errors_regex: "severity: [1-3]" | ||
| examples: | ||
| - "sf code-analyzer run --rule-selector eslint:LWC --workspace . --target '**/lwc/**/*.js' --output-file report.csv" | ||
| install: | ||
| dockerfile: | ||
| - |- | ||
| # renovate: datasource=npm depName=@salesforce/code-analyzer | ||
echoix marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ARG SALESFORCE_SFDX_SCANNER_VERSION=5.5.0 | ||
| - |- | ||
| RUN sf plugins install @salesforce/code-analyzer@${SALESFORCE_SFDX_SCANNER_VERSION} \ | ||
| && (npm cache clean --force || true) \ | ||
| && rm -rf /root/.npm/_cacache | ||
| ide: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.