upgrade code analyzer to v5 #6386
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64,39 +64,38 @@ linters: | |
| linter_spdx_license: BSD-3-Clause | ||
| config_file_name: apex-pmd-ruleset.xml | ||
| cli_executable: sf | ||
| cli_config_arg_name: "--config-file" | ||
| cli_lint_extra_args: | ||
| - "code-analyzer" | ||
| - "run" | ||
| - "--rule-selector" | ||
| - "pmd:Recommended" | ||
| - "--workspace" | ||
| - "." | ||
| - "--output-file" | ||
| - "{{REPORT_FOLDER}}/code-analyzer-report-apex.csv" | ||
| - "--view" | ||
| - "table" | ||
|
There was a problem hiding this comment. Bug: CLI Lint Arguments Configuration Errorcli_lint_extra_args should have each argument on a separate line. According to PR discussion from @nvuillam: "it's one line by argument, so in that can you'll need - code-analyzer - run". The current configuration has "code-analyzer run" as a single entry, which should be split into two separate list entries: "- code-analyzer" and "- run". |
||
| cli_lint_mode: project | ||
| cli_help_extra_args: | ||
| - "code-analyzer run" | ||
| cli_help_extra_commands: | ||
| - "sf code-analyzer rules" | ||
| cli_version_extra_args: | ||
| - "plugins --core" | ||
| cli_version_arg_name: "" | ||
| version_extract_regex: "(?<=code-analyzer )\\d+(\\.\\d+)+" | ||
| cli_lint_errors_count: regex_sum | ||
| cli_lint_errors_regex: "severity: [1-3]" | ||
|
||
| examples: | ||
| - "sf code-analyzer run --rule-selector pmd:Recommended --workspace . --output-file results.csv" | ||
| install: | ||
| dockerfile: | ||
| - |- | ||
| # renovate: datasource=npm depName=@salesforce/code-analyzer | ||
echoix marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ARG SALESFORCE_SFDX_SCANNER_VERSION=5.5.0 | ||
| - |- | ||
| RUN sf plugins install code-analyzer@${SALESFORCE_SFDX_SCANNER_VERSION} \ | ||
| && (npm cache clean --force || true) \ | ||
| && rm -rf /root/.npm/_cacache | ||
| ide: | ||
|
|
@@ -151,37 +150,40 @@ linters: | |
| cli_config_arg_name: ".eslintrc-aura.json" | ||
| cli_executable: sf | ||
| cli_lint_extra_args: | ||
| - "code-analyzer" | ||
| - "run" | ||
| - "--rule-selector" | ||
| - "eslint" | ||
| - "--workspace" | ||
| - "." | ||
|
There was a problem hiding this comment. Bug: Aura Linter Uses Incorrect Rule SelectorThe |
||
| - "--target" | ||
| - "**/aura/**/*.js" | ||
| - "--severity-threshold" | ||
| - "2" | ||
| - "--output-file" | ||
| - "{{REPORT_FOLDER}}/code-analyzer-report-aura.csv" | ||
| - "--view" | ||
| - "table" | ||
|
There was a problem hiding this comment. Bug: Salesforce Linter Argument Compatibility IssueThe Salesforce Aura and LWC linters mix Additional Locations (1)There was a problem hiding this comment. Bug: CLI Lint Arguments Configuration Errorcli_lint_extra_args should have each argument on a separate line. According to PR discussion from @nvuillam: "it's one line by argument, so in that can you'll need - code-analyzer - run". The current configuration has "code-analyzer run" as a single entry, which should be split into two separate list entries: "- code-analyzer" and "- run". |
||
| cli_lint_mode: project | ||
| cli_help_extra_args: | ||
| - "code-analyzer run" | ||
|
||
| cli_help_extra_commands: | ||
| - "sf code-analyzer rules --rule-selector eslint" | ||
| cli_version_extra_args: | ||
| - "plugins --core" | ||
| cli_version_arg_name: "" | ||
| version_extract_regex: "(?<=code-analyzer )\\d+(\\.\\d+)+" | ||
| cli_lint_errors_count: regex_sum | ||
| cli_lint_errors_regex: "severity: [1-3]" | ||
| examples: | ||
| - "sf code-analyzer run --rule-selector eslint --workspace . --file-glob '**/aura/**/*.js' --output-file results.csv" | ||
| install: | ||
| dockerfile: | ||
| - |- | ||
| # renovate: datasource=npm depName=@salesforce/code-analyzer | ||
echoix marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ARG SALESFORCE_SFDX_SCANNER_VERSION=5.5.0 | ||
| - |- | ||
| RUN sf plugins install code-analyzer@${SALESFORCE_SFDX_SCANNER_VERSION} \ | ||
| && (npm cache clean --force || true) \ | ||
| && rm -rf /root/.npm/_cacache | ||
| ide: | ||
|
|
@@ -227,37 +229,40 @@ linters: | |
| cli_config_arg_name: ".eslintrc-lwc.json" | ||
| cli_executable: sf | ||
| cli_lint_extra_args: | ||
| - "code-analyzer" | ||
| - "run" | ||
| - "--rule-selector" | ||
| - "eslint:LWC" | ||
| - "--workspace" | ||
| - "." | ||
| - "--target" | ||
| - "**/lwc/**/*.js" | ||
| - "--severity-threshold" | ||
| - "2" | ||
| - "--output-file" | ||
| - "{{REPORT_FOLDER}}/code-analyzer-report-lwc.csv" | ||
| - "--view" | ||
| - "table" | ||
echoix marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| cli_lint_mode: project | ||
| cli_help_extra_args: | ||
| - "code-analyzer run" | ||
| cli_help_extra_commands: | ||
| - "sf code-analyzer rules --rule-selector eslint:LWC" | ||
| cli_version_extra_args: | ||
| - "plugins --core" | ||
| cli_version_arg_name: "" | ||
| version_extract_regex: "(?<=code-analyzer )\\d+(\\.\\d+)+" | ||
| cli_lint_errors_count: regex_sum | ||
| cli_lint_errors_regex: "severity: [1-3]" | ||
| examples: | ||
| - "sf code-analyzer run --rule-selector eslint:LWC --workspace . --target '**/lwc/**/*.js' --output-file report.csv" | ||
| install: | ||
| dockerfile: | ||
| - |- | ||
| # renovate: datasource=npm depName=@salesforce/code-analyzer | ||
echoix marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ARG SALESFORCE_SFDX_SCANNER_VERSION=5.5.0 | ||
| - |- | ||
| RUN sf plugins install code-analyzer@${SALESFORCE_SFDX_SCANNER_VERSION} \ | ||
| && (npm cache clean --force || true) \ | ||
| && rm -rf /root/.npm/_cacache | ||
| ide: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Duplicate ARG Declaration Causes Renovate Confusion
Duplicate ARG declaration for SALESFORCE_SFDX_SCANNER_VERSION. The variable is defined twice with the same value (5.5.0) but with different renovate datasource comments. The second declaration (line 343-344 with depName=@salesforce/code-analyzer) will override the first one (line 341-342 with depName=@salesforce/plugin-code-analyzer). This appears to be an error as renovate won't be able to track both packages, and it's unclear which package name is correct for version tracking.