Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions template linting fixes #4104

Merged

Conversation

mihaur
Copy link
Contributor

@mihaur mihaur commented Oct 9, 2024

Fixes #
Added fixes for:

Proposed Changes

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Copy link
Contributor

github-actions bot commented Nov 9, 2024

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Nov 9, 2024
@nvuillam
Copy link
Member

@mihaur thanks :)

I agree with all the fixes, except the use of hashes for GitHub actions, not everyone has dependabot / renovate, so I prefer them to target the tag

@github-actions github-actions bot removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Nov 11, 2024
@mihaur
Copy link
Contributor Author

mihaur commented Nov 11, 2024

@nvuillam will update the PR to use versions in GitHub actions.

@nvuillam nvuillam merged commit 4f28d44 into oxsecurity:main Nov 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants