-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Kics Error count properties TEST_KEYWORDS=repository_kics_test #3402
Conversation
HI @nvuillam, I believe I have implemented the change you suggested, but I'm not certain how to verify it is working correctly. Do you simply need to approve the test workflow? I also considered adding ERROR and SUCCESS reports to the automation tests for additional testing when KICS runs. However, since KICS produces quite a bit of output compared to other linters, I wasn't sure if that would work well? I also wasnt sure if this was even needed. Any guidance you can provide on testing the change would be greatly appreciated. Please let me know if you need any clarification or have additional suggestions. regards |
@TommyE123 error and success report files are from a previous version of MegaLinter and i think i broke it somehow ^^ You can add the example fils if you want, it's still good for documentation :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, thanks for your contribution :)
Link to issue: #3392
Fixes
The Kics linter is incorrectly reporting the number of errors. This discrepancy becomes apparent when running the linter on files with multiple warnings or errors, as MegaLinter incorrectly displays "1" error instead of the actual count in the summary.
The linter descriptor must contain properties
cli_lint_errors_count
andcli_lint_errors_regex
to be able to count the errors by getting info from the linter output log.Proposed Changes
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance