Fix sendgrid send_plain_text #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, looks good to me. I'll update the default url via the spec and regenerate from there. |
augustuswm
pushed a commit
that referenced
this pull request
Mar 28, 2023
* Use url() to get correct url * Clean up method
augustuswm
added a commit
that referenced
this pull request
Jun 12, 2023
* Initial sketch * Remove trait. Update test * Do not generate empty serde attributes * Fix spec and root server * Fix sendgrid send_plain_text (#65) * Use url() to get correct url * Clean up method * Add test * Bump version * Fix empty serde attributes * Fix chrono call * Fix deprecation * Chrono fix * Align spec urls with previously used urls * Update drive traits to use url method * Fmt * Fix intro docs for client with multiple root servers * Fix created param format for GitHub workflow listing * Rebuild * Bump h2 * Bump openssl * Fix h2 ck * Add openssl-macros * Comment and derive cleanup * Derive default on fully qualified path * Bump base64 * Bump reqwest-middleware * Remove default opentel feature * Update trait responses * Fmt * Update versions * Add changelog * Add headers to errors * Rust indicators * Add change not about default features * Add redirect policy to remaining clients * Re-export reqwest types * Clarify response values * Clarify new env fns * Clarify docs for constructors and panics * Remove tokio full feature * Fix Google clients with command urls --------- Co-authored-by: Adam Sunderland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The url wasn't getting created correctly, so we just pass it through the method on the trait. I also refactored the method a bit to make clippy happy.
@augustuswm I can also change the default URL to https, wasn't sure if you wanted to fix that elsewhere or just manually here.