[github] Add HttpCache::in_dir constructor to allow for custom cache placement
#59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before only the home dir could be used, this makes it a bit more ergonomic if the user has other desires
ginger51011
changed the title
HttpCache::in_dir constructor to allow for custom cache placementHttpCache::in_dir constructor to allow for custom cache placement
|
Makes sense to me. Only suggestion is that pub fn in_home_dir() -> BoxedHttpCache {
Self::in_dir(&dirs::home_dir().expect("Expected a home dir"))
} |
Good point, added that! |
kavin-kr
pushed a commit
to kavin-kr/third-party-api-clients
that referenced
this pull request
Mar 28, 2023
…e placement (oxidecomputer#59) * Add HttpCache::in_dir constructor to allow for custom cache placement Before only the home dir could be used, this makes it a bit more ergonomic if the user has other desires * Use HttpCache::in_dir for HttpCache::in_home_dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before only the home dir could be used, this makes it a bit more ergonomic if the user has other desires.