Add address lot resource and data source.#489
Merged
Conversation
Contributor
Author
|
Manual acceptance testing, for now: |
f8537d9 to
2d53051
Compare
Contributor
|
Looks like this resolves #306 as well |
sudomateo
reviewed
Aug 14, 2025
Collaborator
There was a problem hiding this comment.
Nice work on this! I left some feedback to update documentation and to confirm that the nested id attribute within the blocks attribute is okay because we've seen issues with non-empty refresh plans in the past with such a setup. I've discussed this issue on other pull requests (#426 (comment)) if you're curious for context.
sudomateo
reviewed
Aug 18, 2025
Collaborator
sudomateo
left a comment
There was a problem hiding this comment.
Just noting that this will also need a changelog entry.
4 tasks
f8be494 to
f2f5093
Compare
Collaborator
|
@jmcarp need anything to get this over the line? |
f2f5093 to
56f177f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #468.
Resolves #469.