Skip to content

Add address lot resource and data source.#489

Merged
sudomateo merged 1 commit intomainfrom
jmcarp/address-lot
Dec 20, 2025
Merged

Add address lot resource and data source.#489
sudomateo merged 1 commit intomainfrom
jmcarp/address-lot

Conversation

@jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Aug 13, 2025

Resolves #468.
Resolves #469.

@jmcarp jmcarp requested a review from a team as a code owner August 13, 2025 13:52
@jmcarp
Copy link
Contributor Author

jmcarp commented Aug 13, 2025

Manual acceptance testing, for now:

❯ TEST_ACC_NAME=TestAccAddressLot make testacc          
-> Running terraform acceptance tests
=== RUN   TestAccAddressLot
=== PAUSE TestAccAddressLot
=== CONT  TestAccAddressLot
--- PASS: TestAccAddressLot (1.91s)
PASS
ok  	github.com/oxidecomputer/terraform-provider-oxide/internal/provider	2.258s
❯ TEST_ACC_NAME=TestAccDataSourceAddressLot make testacc
-> Running terraform acceptance tests
=== RUN   TestAccDataSourceAddressLot
=== PAUSE TestAccDataSourceAddressLot
=== CONT  TestAccDataSourceAddressLot
--- PASS: TestAccDataSourceAddressLot (0.92s)
PASS
ok  	github.com/oxidecomputer/terraform-provider-oxide/internal/provider	1.270s

@jmcarp jmcarp force-pushed the jmcarp/address-lot branch 2 times, most recently from f8537d9 to 2d53051 Compare August 13, 2025 15:04
@internet-diglett
Copy link
Contributor

Looks like this resolves #306 as well

@sudomateo sudomateo linked an issue Aug 14, 2025 that may be closed by this pull request
Copy link
Collaborator

@sudomateo sudomateo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this! I left some feedback to update documentation and to confirm that the nested id attribute within the blocks attribute is okay because we've seen issues with non-empty refresh plans in the past with such a setup. I've discussed this issue on other pull requests (#426 (comment)) if you're curious for context.

Copy link
Collaborator

@sudomateo sudomateo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that this will also need a changelog entry.

@jmcarp jmcarp force-pushed the jmcarp/address-lot branch 2 times, most recently from f8be494 to f2f5093 Compare August 22, 2025 19:43
Copy link
Collaborator

@jmcarp need anything to get this over the line?

@sudomateo sudomateo merged commit 68a4a21 into main Dec 20, 2025
2 checks passed
@sudomateo sudomateo deleted the jmcarp/address-lot branch December 20, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create address lot data source Create address lot resource System Networking - Address Lots

3 participants