Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pre_hook (sync) make request mutable #825

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drahnr
Copy link
Contributor

@drahnr drahnr commented Jun 8, 2024

Obsoletes #823

Copy link
Collaborator

@ahl ahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sort of surprised that we don't have a test that validates this. What will existing users of pre_hook experience other than a type error if they've specified the type in their pre_hook closure or fn?

@drahnr
Copy link
Contributor Author

drahnr commented Jun 13, 2024

I'm sort of surprised that we don't have a test that validates this. What will existing users of pre_hook experience other than a type error if they've specified the type in their pre_hook closure or fn?

Can you rephrase, I am not sure I understand what your concern is. Do you want an interface check for the provided TokenStream or are you concern re change in behviour for existing users that expect an &Request as argument?

@ahl
Copy link
Collaborator

ahl commented Jun 13, 2024

If there is an existing user of the pre_hook interface, what will those users experience with this change? Will everything just work or will compilation fail with an error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants